Springify: Testfall repariert - Seltsames Verhalten von `@KafkaHandler`!

[demos/kafka/training] / src / test / java / de / juplo / kafka / ApplicationTests.java

diff --git a/src/test/java/de/juplo/kafka/ApplicationTests.java b/src/test/java/de/juplo/kafka/ApplicationTests.java
index 3a10cd1..f13fdde 100644 (file)
--- a/src/test/java/de/juplo/kafka/ApplicationTests.java
+++ b/src/test/java/de/juplo/kafka/ApplicationTests.java
@@ -1,12 +1,10 @@
 package de.juplo.kafka;
 
 import lombok.extern.slf4j.Slf4j;
-import org.apache.kafka.clients.consumer.ConsumerRecord;
 import org.apache.kafka.clients.consumer.KafkaConsumer;
 import org.apache.kafka.clients.producer.KafkaProducer;
 import org.apache.kafka.clients.producer.ProducerRecord;
 import org.apache.kafka.common.TopicPartition;
-import org.apache.kafka.common.errors.RecordDeserializationException;
 import org.apache.kafka.common.serialization.*;
 import org.apache.kafka.common.utils.Bytes;
 import org.junit.jupiter.api.*;
@@ -18,7 +16,7 @@ import org.springframework.boot.test.context.TestConfiguration;
 import org.springframework.context.annotation.Bean;
 import org.springframework.context.annotation.Import;
 import org.springframework.context.annotation.Primary;
-import org.springframework.kafka.listener.MessageListenerContainer;
+import org.springframework.kafka.listener.adapter.ConsumerRecordMetadata;
 import org.springframework.kafka.support.serializer.JsonSerializer;
 import org.springframework.kafka.test.context.EmbeddedKafka;
 import org.springframework.test.context.TestPropertySource;
@@ -29,7 +27,6 @@ import java.util.*;
 import java.util.concurrent.ExecutionException;
 import java.util.function.BiConsumer;
 import java.util.function.BiFunction;
-import java.util.function.Consumer;
 import java.util.stream.Collectors;
 import java.util.stream.IntStream;
 
@@ -45,7 +42,6 @@ import static org.awaitility.Awaitility.*;
                                EndlessConsumer.class,
                                KafkaAutoConfiguration.class,
                                ApplicationTests.Configuration.class })
-@TestMethodOrder(MethodOrderer.OrderAnnotation.class)
 @TestPropertySource(
                properties = {
                                "spring.kafka.consumer.bootstrap-servers=${spring.embedded.kafka.brokers}",
@@ -66,8 +62,6 @@ class ApplicationTests
        @Autowired
        KafkaProducer<String, Bytes> kafkaProducer;
        @Autowired
-       org.apache.kafka.clients.consumer.Consumer<String, ClientMessage> kafkaConsumer;
-       @Autowired
        KafkaConsumer<Bytes, Bytes> offsetConsumer;
        @Autowired
        ApplicationProperties applicationProperties;
@@ -76,24 +70,23 @@ class ApplicationTests
        @Autowired
        EndlessConsumer endlessConsumer;
        @Autowired
-       RecordHandler recordHandler;
+       ClientMessageHandler clientMessageHandler;
 
        Map<TopicPartition, Long> oldOffsets;
        Map<TopicPartition, Long> newOffsets;
-       Set<ConsumerRecord<String, ClientMessage>> receivedRecords;
+       Set<ClientMessage> received;
 
 
        /** Tests methods */
 
        @Test
-       @Order(1) // << The poistion pill is not skipped. Hence, this test must run first
        void commitsCurrentOffsetsOnSuccess() throws ExecutionException, InterruptedException
        {
                send100Messages((key, counter) -> serialize(key, counter));
 
                await("100 records received")
                                .atMost(Duration.ofSeconds(30))
-                               .until(() -> receivedRecords.size() == 100);
+                               .until(() -> received.size() == 100);
 
                await("Offsets committed")
                                .atMost(Duration.ofSeconds(10))
@@ -109,8 +102,7 @@ class ApplicationTests
        }
 
        @Test
-       @Order(2)
-       void commitsCurrentOffsetsOnError()
+       void commitsCurrentOffsetsOnDeserializationError()
        {
                send100Messages((key, counter) ->
                                counter == 77
@@ -119,7 +111,7 @@ class ApplicationTests
 
                await("99 records received")
                                .atMost(Duration.ofSeconds(30))
-                               .until(() -> receivedRecords.size() == 99);
+                               .until(() -> received.size() == 99);
 
                await("Offsets committed")
                                .atMost(Duration.ofSeconds(10))
@@ -141,6 +133,35 @@ class ApplicationTests
                                .isTrue();
        }
 
+       @Test
+       void commitsOffsetOnProgramLogicErrorFoo()
+       {
+               clientMessageHandler.testHandler = (clientMessage, metadata) ->
+               {
+                       if (Integer.parseInt(clientMessage.message)%10 ==0)
+                               throw new RuntimeException("BOOM: " + clientMessage.message + "%10 == 0");
+               };
+
+               send100Messages((key, counter) -> serialize(key, counter));
+
+               await("80 records received")
+                               .atMost(Duration.ofSeconds(30))
+                               .until(() -> received.size() == 100);
+
+               await("Offsets committed")
+                               .atMost(Duration.ofSeconds(10))
+                               .pollDelay(Duration.ofSeconds(1))
+                               .untilAsserted(() ->
+                               {
+                                       checkSeenOffsetsForProgress();
+                                       compareToCommitedOffsets(newOffsets);
+                               });
+
+               assertThat(endlessConsumer.isRunning())
+                               .describedAs("Consumer should still be running")
+                               .isTrue();
+       }
+
 
        /** Helper methods for the verification of expectations */
 
@@ -250,11 +271,11 @@ class ApplicationTests
        @BeforeEach
        public void init()
        {
-               recordHandler.testHandler = (record) -> {};
+               clientMessageHandler.testHandler = (clientMessage, metadata) -> {};
 
                oldOffsets = new HashMap<>();
                newOffsets = new HashMap<>();
-               receivedRecords = new HashSet<>();
+               received = new HashSet<>();
 
                doForCurrentOffsets((tp, offset) ->
                {
@@ -262,14 +283,13 @@ class ApplicationTests
                        newOffsets.put(tp, offset - 1);
                });
 
-               recordHandler.captureOffsets =
-                               record ->
+               clientMessageHandler.captureOffsets =
+                               (clientMessage, metadata) ->
                                {
-                                       receivedRecords.add(record);
-                                       log.debug("TEST: Processing record #{}: {}", receivedRecords.size(), record.value());
+                                       received.add(clientMessage);
+                                       log.debug("TEST: Processing record #{}: {}", received.size(), clientMessage);
                                        newOffsets.put(
-                                                       new TopicPartition(record.topic(), record.partition()),
-                                                       record.offset());
+                                                       new TopicPartition(metadata.topic(), metadata.partition()), metadata.offset());
                                };
 
                endlessConsumer.start();
@@ -288,18 +308,18 @@ class ApplicationTests
                }
        }
 
-       public static class RecordHandler implements Consumer<ConsumerRecord<String, ClientMessage>>
+       public static class ClientMessageHandler implements BiConsumer<ClientMessage, ConsumerRecordMetadata>
        {
-               Consumer<ConsumerRecord<String, ClientMessage>> captureOffsets;
-               Consumer<ConsumerRecord<String, ClientMessage>> testHandler;
+               BiConsumer<ClientMessage, ConsumerRecordMetadata> captureOffsets;
+               BiConsumer<ClientMessage, ConsumerRecordMetadata> testHandler;
 
 
                @Override
-               public void accept(ConsumerRecord<String, ClientMessage> record)
+               public void accept(ClientMessage clientMessage, ConsumerRecordMetadata metadata)
                {
                        captureOffsets
                                        .andThen(testHandler)
-                                       .accept(record);
+                                       .accept(clientMessage, metadata);
                }
        }
 
@@ -309,9 +329,9 @@ class ApplicationTests
        {
                @Primary
                @Bean
-               public Consumer<ConsumerRecord<String, ClientMessage>> testHandler()
+               public BiConsumer<ClientMessage, ConsumerRecordMetadata> testHandler()
                {
-                       return new RecordHandler();
+                       return new ClientMessageHandler();
                }
 
                @Bean