X-Git-Url: http://juplo.de/gitweb/?a=blobdiff_plain;f=src%2Ftest%2Fjava%2Fde%2Fjuplo%2Fkafka%2Fchat%2Fbackend%2Fapi%2FChatBackendControllerTest.java;h=b72294d95611292d55b42db52422b3c142f48b80;hb=7281b4220170f451062bb32e0d5f63ec48d141d3;hp=4392968daa410377c19a7262a822d0a5698d1523;hpb=f2f0cdc6901d1117ac385e10e2c8a28a1886726c;p=demos%2Fkafka%2Fchat diff --git a/src/test/java/de/juplo/kafka/chat/backend/api/ChatBackendControllerTest.java b/src/test/java/de/juplo/kafka/chat/backend/api/ChatBackendControllerTest.java index 4392968d..b72294d9 100644 --- a/src/test/java/de/juplo/kafka/chat/backend/api/ChatBackendControllerTest.java +++ b/src/test/java/de/juplo/kafka/chat/backend/api/ChatBackendControllerTest.java @@ -1,8 +1,8 @@ package de.juplo.kafka.chat.backend.api; import de.juplo.kafka.chat.backend.domain.*; +import de.juplo.kafka.chat.backend.persistence.inmemory.InMemoryChatHomeService; import lombok.extern.slf4j.Slf4j; -import org.junit.jupiter.api.Disabled; import org.junit.jupiter.api.DisplayName; import org.junit.jupiter.api.Test; import org.springframework.beans.factory.annotation.Autowired; @@ -11,35 +11,40 @@ import org.springframework.boot.test.context.SpringBootTest; import org.springframework.boot.test.mock.mockito.MockBean; import org.springframework.http.MediaType; import org.springframework.test.web.reactive.server.WebTestClient; +import reactor.core.publisher.Mono; -import java.util.Optional; +import java.time.Clock; +import java.time.LocalDateTime; import java.util.UUID; import static org.mockito.ArgumentMatchers.any; -import static org.mockito.Mockito.when; +import static org.mockito.Mockito.*; -@SpringBootTest(properties = "spring.main.allow-bean-definition-overriding=true") +@SpringBootTest(properties = { + "spring.main.allow-bean-definition-overriding=true", + "chat.backend.inmemory.sharding-strategy=none" }) @AutoConfigureWebTestClient @Slf4j public class ChatBackendControllerTest { @MockBean - ChatHome chatHome; + InMemoryChatHomeService chatHomeService; + @MockBean + ChatRoomService chatRoomService; - @Disabled @Test @DisplayName("Assert expected problem-details for unknown chatroom on GET /list/{chatroomId}") void testUnknownChatroomExceptionForListChatroom(@Autowired WebTestClient client) { // Given UUID chatroomId = UUID.randomUUID(); - when(chatHome.getChatroom(any(UUID.class))).thenReturn(Optional.empty()); + when(chatHomeService.getChatRoom(anyInt(), any(UUID.class))).thenReturn(Mono.empty()); // When WebTestClient.ResponseSpec responseSpec = client .get() - .uri("/list/{chatroomId}", chatroomId) + .uri("/{chatroomId}/list", chatroomId) .accept(MediaType.APPLICATION_JSON) .exchange(); @@ -48,19 +53,18 @@ public class ChatBackendControllerTest } - @Disabled @Test @DisplayName("Assert expected problem-details for unknown chatroom on GET /get/{chatroomId}") void testUnknownChatroomExceptionForGetChatroom(@Autowired WebTestClient client) { // Given UUID chatroomId = UUID.randomUUID(); - when(chatHome.getChatroom(any(UUID.class))).thenReturn(Optional.empty()); + when(chatHomeService.getChatRoom(anyInt(), any(UUID.class))).thenReturn(Mono.empty()); // When WebTestClient.ResponseSpec responseSpec = client .get() - .uri("/get/{chatroomId}", chatroomId) + .uri("/{chatroomId}", chatroomId) .accept(MediaType.APPLICATION_JSON) .exchange(); @@ -76,13 +80,13 @@ public class ChatBackendControllerTest UUID chatroomId = UUID.randomUUID(); String username = "foo"; Long messageId = 66l; - when(chatHome.getChatroom(any(UUID.class))).thenReturn(Optional.empty()); + when(chatHomeService.getChatRoom(anyInt(), any(UUID.class))).thenReturn(Mono.empty()); // When WebTestClient.ResponseSpec responseSpec = client .put() .uri( - "/put/{chatroomId}/{username}/{messageId}", + "/{chatroomId}/{username}/{messageId}", chatroomId, username, messageId) @@ -102,13 +106,13 @@ public class ChatBackendControllerTest UUID chatroomId = UUID.randomUUID(); String username = "foo"; Long messageId = 66l; - when(chatHome.getChatroom(any(UUID.class))).thenReturn(Optional.empty()); + when(chatHomeService.getChatRoom(anyInt(), any(UUID.class))).thenReturn(Mono.empty()); // When WebTestClient.ResponseSpec responseSpec = client .get() .uri( - "/get/{chatroomId}/{username}/{messageId}", + "/{chatroomId}/{username}/{messageId}", chatroomId, username, messageId) @@ -125,13 +129,13 @@ public class ChatBackendControllerTest { // Given UUID chatroomId = UUID.randomUUID(); - when(chatHome.getChatroom(any(UUID.class))).thenReturn(Optional.empty()); + when(chatHomeService.getChatRoom(anyInt(), any(UUID.class))).thenReturn(Mono.empty()); // When WebTestClient.ResponseSpec responseSpec = client .get() - .uri("/listen/{chatroomId}", chatroomId) - .accept(MediaType.TEXT_EVENT_STREAM, MediaType.APPLICATION_JSON) + .uri("/{chatroomId}/listen", chatroomId) + // .accept(MediaType.TEXT_EVENT_STREAM, MediaType.APPLICATION_JSON) << TODO: Does not work! .exchange(); // Then @@ -148,4 +152,103 @@ public class ChatBackendControllerTest .jsonPath("$.type").isEqualTo("/problem/unknown-chatroom") .jsonPath("$.chatroomId").isEqualTo(chatroomId.toString()); } + + @Test + @DisplayName("Assert expected problem-details for message mutation on PUT /put/{chatroomId}/{username}/{messageId}") + void testMessageMutationException(@Autowired WebTestClient client) throws Exception + { + // Given + UUID chatroomId = UUID.randomUUID(); + String user = "foo"; + Long messageId = 66l; + Message.MessageKey key = Message.MessageKey.of(user, messageId); + Long serialNumberExistingMessage = 0l; + String timeExistingMessageAsString = "2023-01-09T20:44:57.389665447"; + LocalDateTime timeExistingMessage = LocalDateTime.parse(timeExistingMessageAsString); + String textExistingMessage = "Existing"; + String textMutatedMessage = "Mutated!"; + ChatRoom chatRoom = new ChatRoom( + chatroomId, + "Test-ChatRoom", + 0, + Clock.systemDefaultZone(), + chatRoomService, 8); + when(chatHomeService.getChatRoom(anyInt(), any(UUID.class))).thenReturn(Mono.just(chatRoom)); + Message existingMessage = new Message( + key, + serialNumberExistingMessage, + timeExistingMessage, + textExistingMessage); + when(chatRoomService.getMessage(any(Message.MessageKey.class))) + .thenReturn(Mono.just(existingMessage)); + // Needed for readable error-reports, in case of a bug that leads to according unwanted call + when(chatRoomService.persistMessage(any(Message.MessageKey.class), any(LocalDateTime.class), any(String.class))) + .thenReturn(Mono.just(mock(Message.class))); + + // When + client + .put() + .uri( + "/{chatroomId}/{username}/{messageId}", + chatroomId, + user, + messageId) + .bodyValue(textMutatedMessage) + .accept(MediaType.APPLICATION_JSON) + .exchange() + // Then + .expectStatus().is4xxClientError() + .expectBody() + .jsonPath("$.type").isEqualTo("/problem/message-mutation") + .jsonPath("$.existingMessage.id").isEqualTo(messageId) + .jsonPath("$.existingMessage.serial").isEqualTo(serialNumberExistingMessage) + .jsonPath("$.existingMessage.time").isEqualTo(timeExistingMessageAsString) + .jsonPath("$.existingMessage.user").isEqualTo(user) + .jsonPath("$.existingMessage.text").isEqualTo(textExistingMessage) + .jsonPath("$.mutatedText").isEqualTo(textMutatedMessage); + verify(chatRoomService, never()).persistMessage(eq(key), any(LocalDateTime.class), any(String.class)); + } + + @Test + @DisplayName("Assert expected problem-details for invalid username on PUT /put/{chatroomId}/{username}/{messageId}") + void testInvalidUsernameException(@Autowired WebTestClient client) throws Exception + { + // Given + UUID chatroomId = UUID.randomUUID(); + String user = "Foo"; + Long messageId = 66l; + Message.MessageKey key = Message.MessageKey.of(user, messageId); + String textMessage = "Hallo Welt"; + ChatRoom chatRoom = new ChatRoom( + chatroomId, + "Test-ChatRoom", + 0, + Clock.systemDefaultZone(), + chatRoomService, 8); + when(chatHomeService.getChatRoom(anyInt(), any(UUID.class))) + .thenReturn(Mono.just(chatRoom)); + when(chatRoomService.getMessage(any(Message.MessageKey.class))) + .thenReturn(Mono.empty()); + // Needed for readable error-reports, in case of a bug that leads to according unwanted call + when(chatRoomService.persistMessage(any(Message.MessageKey.class), any(LocalDateTime.class), any(String.class))) + .thenReturn(Mono.just(mock(Message.class))); + + // When + client + .put() + .uri( + "/{chatroomId}/{username}/{messageId}", + chatroomId, + user, + messageId) + .bodyValue(textMessage) + .accept(MediaType.APPLICATION_JSON) + .exchange() + // Then + .expectStatus().is4xxClientError() + .expectBody() + .jsonPath("$.type").isEqualTo("/problem/invalid-username") + .jsonPath("$.username").isEqualTo(user); + verify(chatRoomService, never()).persistMessage(eq(key), any(LocalDateTime.class), any(String.class)); + } }