Bedingungsloser Reset (und besserer Methoden-Name) für `BackOffState`

diff --git a/src/main/java/de/juplo/kafka/BackOffState.java b/src/main/java/de/juplo/kafka/BackOffState.java
index 4981bb6c45fe314529d23eb25c0bd2f6cd93b858..a51b5a985a08de96ae9c75a6668a38dc5308eff1 100644 (file)
--- a/src/main/java/de/juplo/kafka/BackOffState.java
+++ b/src/main/java/de/juplo/kafka/BackOffState.java
@@ -95,20 +95,9 @@ class BackOffState
     return this.offset == offset && timeNextRetryIsDue == null;
   }
 
-  void markAsCompleted()
+  void reset()
   {
-    if (timeNextRetryIsDue != null)
-    {
-      log.info(
-        "{} - {}. retry for offset={} in {} succeeded after {}",
-        id,
-        numRetries,
-        offset,
-        topicPartition,
-        Duration.between(startTime, timeNextRetryIsDue));
-
-      timeNextRetryIsDue = null;
-    }
+    timeNextRetryIsDue = null;
   }
 
   private void initializeNextBackOff()

diff --git a/src/main/java/de/juplo/kafka/ExampleConsumer.java b/src/main/java/de/juplo/kafka/ExampleConsumer.java
index 9e73b1196443f09432ae7123543c303bf891c4c3..b767ca82f300a08ee8d7a07fcf14b49b999eddb0 100644 (file)
--- a/src/main/java/de/juplo/kafka/ExampleConsumer.java
+++ b/src/main/java/de/juplo/kafka/ExampleConsumer.java
@@ -178,7 +178,7 @@ public class ExampleConsumer implements ConsumerRebalanceListener, Runnable
                 log.warn("{} - Ignoring non-retryable error: {}", id, e.toString());
               }
 
-              backOffState[topicPartition.partition()].markAsCompleted();
+              backOffState[topicPartition.partition()].reset();
             }
           }
         }

diff --git a/src/test/java/de/juplo/kafka/BackOffStateTest.java b/src/test/java/de/juplo/kafka/BackOffStateTest.java
index 338631c156eb7df599f31eea78972e617c878ead..7160768db9622ee6d848b9026643b1407c37ccca 100644 (file)
--- a/src/test/java/de/juplo/kafka/BackOffStateTest.java
+++ b/src/test/java/de/juplo/kafka/BackOffStateTest.java
@@ -263,14 +263,14 @@ class BackOffStateTest
   }
 
   @Test
-  @DisplayName("A started BackOffState is not waiting for a retry if it is marked as completed")
-  void StartedBackOffStateIsNotWaitingForRetryIfMarkedCompleted()
+  @DisplayName("A started BackOffState is not waiting for a retry after a reset")
+  void StartedBackOffStateIsNotWaitingForRetryAfterReset()
   {
     // GIVEN
     BackOffState backOffState = StartedBackoffStateWithRetries();
 
     // WHEN
-    backOffState.markAsCompleted();
+    backOffState.reset();
 
     // THEN
     assertThat(backOffState.isWaitingForNextRetry()).isFalse();
@@ -284,7 +284,7 @@ class BackOffStateTest
     BackOffState backOffState = StartedBackoffStateWithRetries();
 
     // WHEN
-    backOffState.markAsCompleted();
+    backOffState.reset();
 
     // THEN
     assertThat(backOffState.isStarted(OFFSET)).isTrue();