From: Kai Moritz <kai@juplo.de>
Date: Tue, 16 Aug 2022 15:48:27 +0000 (+0200)
Subject: refactor: Inline-Klasse in `ApplicationTests` ist jetzt statische Klasse
X-Git-Tag: sumup-adder---lvm-2-tage~12
X-Git-Url: http://juplo.de/gitweb/?a=commitdiff_plain;h=55d4ad6e7ccbd5d284d7bcda7cfc857555fcd0a5;p=demos%2Fkafka%2Ftraining

refactor: Inline-Klasse in `ApplicationTests` ist jetzt statische Klasse

* Diese Refaktorisierung ist nötig, damit dem `RecordGenerator`
  der Zugriff auf die Ergebnisse der Fachlogik in `AdderResults`
  ermöglicht werden kann.
* Grund: Wenn der `RecordGenerator` bereits im Konstruktor erzeugt wird,
  kann er nicht auf die `this`-Referenz von `ApplicationTests` zugreifen.
---

diff --git a/src/test/java/de/juplo/kafka/ApplicationTests.java b/src/test/java/de/juplo/kafka/ApplicationTests.java
index 9dda079..1a336d6 100644
--- a/src/test/java/de/juplo/kafka/ApplicationTests.java
+++ b/src/test/java/de/juplo/kafka/ApplicationTests.java
@@ -12,71 +12,72 @@ public class ApplicationTests extends GenericApplicationTests<String, String>
 {
   public ApplicationTests()
   {
-    super(
-        new RecordGenerator()
+    super(new ApplicationTestRecrodGenerator());
+  }
+
+
+  static class ApplicationTestRecrodGenerator implements RecordGenerator
+  {
+    final int[] numbers = {1, 7, 3, 2, 33, 6, 11};
+    final String[] dieWilden13 =
+        IntStream
+            .range(1, 14)
+            .mapToObj(i -> "seeräuber-" + i)
+            .toArray(i -> new String[i]);
+    final StringSerializer stringSerializer = new StringSerializer();
+    final Bytes calculateMessage = new Bytes(stringSerializer.serialize(TOPIC, "CALCULATE"));
+
+    int counter = 0;
+
+    @Override
+    public int generate(
+        boolean poisonPills,
+        boolean logicErrors,
+        Consumer<ProducerRecord<Bytes, Bytes>> messageSender)
+    {
+      counter = 0;
+
+      for (int i = 0; i < 33; i++)
+      {
+        String seeräuber = dieWilden13[i % 13];
+        int number = numbers[i % 7];
+
+        Bytes key = new Bytes(stringSerializer.serialize(TOPIC, seeräuber));
+
+        for (int message = 1; message <= number; message++)
         {
-          final int[] numbers = { 1, 7, 3, 2, 33, 6, 11 };
-          final String[] dieWilden13 =
-              IntStream
-                  .range(1,14)
-                  .mapToObj(i -> "seeräuber-" + i)
-                  .toArray(i -> new String[i]);
-          final StringSerializer stringSerializer = new StringSerializer();
-          final Bytes calculateMessage = new Bytes(stringSerializer.serialize(TOPIC, "CALCULATE"));
-
-          int counter = 0;
-
-
-          @Override
-          public int generate(
-              boolean poisonPills,
-              boolean logicErrors,
-              Consumer<ProducerRecord<Bytes, Bytes>> messageSender)
-          {
-            counter = 0;
-
-            for (int i = 0; i < 33; i++)
-            {
-              String seeräuber = dieWilden13[i%13];
-              int number = numbers[i%7];
-
-              Bytes key = new Bytes(stringSerializer.serialize(TOPIC, seeräuber));
-
-              for (int message = 1; message <= number; message++)
-              {
-                Bytes value = new Bytes(stringSerializer.serialize(TOPIC, Integer.toString(message)));
-                send(key, value, logicErrors, messageSender);
-              }
-              send(key, calculateMessage, logicErrors, messageSender);
-            }
-
-            return counter;
-          }
-
-          void send(
-              Bytes key,
-              Bytes value,
-              boolean logicErrors,
-              Consumer<ProducerRecord<Bytes, Bytes>> messageSender)
-          {
-            counter++;
-
-            if (counter == 77)
-            {
-              if (logicErrors)
-              {
-                value = new Bytes(stringSerializer.serialize(TOPIC, Integer.toString(-1)));
-              }
-            }
-
-            messageSender.accept(new ProducerRecord<>(TOPIC, key, value));
-          }
-
-          @Override
-          public boolean canGeneratePoisonPill()
-          {
-            return false;
-          }
-        });
+          Bytes value = new Bytes(stringSerializer.serialize(TOPIC, Integer.toString(message)));
+          send(key, value, logicErrors, messageSender);
+        }
+        send(key, calculateMessage, logicErrors, messageSender);
+      }
+
+      return counter;
+    }
+
+    void send(
+        Bytes key,
+        Bytes value,
+        boolean logicErrors,
+        Consumer<ProducerRecord<Bytes, Bytes>> messageSender)
+    {
+      counter++;
+
+      if (counter == 77)
+      {
+        if (logicErrors)
+        {
+          value = new Bytes(stringSerializer.serialize(TOPIC, Integer.toString(-1)));
+        }
+      }
+
+      messageSender.accept(new ProducerRecord<>(TOPIC, key, value));
+    }
+
+    @Override
+    public boolean canGeneratePoisonPill()
+    {
+      return false;
+    }
   }
 }