From 24e2917e5580e2ac2f5f9268082aa6b540b2268e Mon Sep 17 00:00:00 2001
From: Kai Moritz <kai@juplo.de>
Date: Sat, 2 Sep 2023 10:35:39 +0200
Subject: [PATCH] test: RED - Added a test for a put to a non-existent
 chat-room

---
 .../chat/backend/AbstractConfigurationIT.java | 34 ++++++++++++++++++-
 .../AbstractConfigurationWithShardingIT.java  |  8 ++++-
 2 files changed, 40 insertions(+), 2 deletions(-)

diff --git a/src/test/java/de/juplo/kafka/chat/backend/AbstractConfigurationIT.java b/src/test/java/de/juplo/kafka/chat/backend/AbstractConfigurationIT.java
index 53ad04ea..00734f26 100644
--- a/src/test/java/de/juplo/kafka/chat/backend/AbstractConfigurationIT.java
+++ b/src/test/java/de/juplo/kafka/chat/backend/AbstractConfigurationIT.java
@@ -10,6 +10,8 @@ import org.testcontainers.shaded.org.awaitility.Awaitility;
 
 import java.time.Duration;
 
+import static org.hamcrest.Matchers.endsWith;
+
 
 public abstract class AbstractConfigurationIT
 {
@@ -18,6 +20,7 @@ public abstract class AbstractConfigurationIT
   @Autowired
   WebTestClient webTestClient;
 
+
   @Test
   @DisplayName("The app starts, the data is restored and accessible")
   void testAppStartsDataIsRestoredAndAccessible()
@@ -50,7 +53,8 @@ public abstract class AbstractConfigurationIT
                 .jsonPath("$[0].name").isEqualTo("FOO");
           webTestClient
               .get()
-              .uri("http://localhost:{port}/{chatRoomId}",
+              .uri(
+                  "http://localhost:{port}/{chatRoomId}",
                   port,
                   chatRoomId)
               .accept(MediaType.APPLICATION_JSON)
@@ -79,4 +83,32 @@ public abstract class AbstractConfigurationIT
               .expectBody().jsonPath("$.text").isEqualTo("Hallo, ich heiße Peter!");
         });
   }
+
+  @Test
+  @DisplayName("A PUT-message for a non-existent chat-room yields 404 NOT FOUND")
+  void testNotFoundForPutMessageToNonExistentChatRoom()
+  {
+    String otherChatRoomId = "7f59ec77-832e-4a17-8d22-55ef46242c17";
+
+    Awaitility
+        .await()
+        .atMost(Duration.ofSeconds(15))
+        .untilAsserted(() ->
+        {
+          webTestClient
+              .put()
+              .uri(
+                  "http://localhost:{port}/{chatRoomId}/otto/66",
+                  port,
+                  otherChatRoomId)
+              .contentType(MediaType.TEXT_PLAIN)
+              .accept(MediaType.APPLICATION_JSON)
+              .bodyValue("The devil rules route 66")
+              .exchange()
+              .expectStatus().isNotFound()
+              .expectBody()
+                .jsonPath("$.type").value(endsWith("/problem/unknown-chatroom"))
+                .jsonPath("$.chatroomId").isEqualTo(otherChatRoomId);
+        });
+  }
 }
diff --git a/src/test/java/de/juplo/kafka/chat/backend/AbstractConfigurationWithShardingIT.java b/src/test/java/de/juplo/kafka/chat/backend/AbstractConfigurationWithShardingIT.java
index e6fd95a9..5c9ac13f 100644
--- a/src/test/java/de/juplo/kafka/chat/backend/AbstractConfigurationWithShardingIT.java
+++ b/src/test/java/de/juplo/kafka/chat/backend/AbstractConfigurationWithShardingIT.java
@@ -7,6 +7,8 @@ import org.testcontainers.shaded.org.awaitility.Awaitility;
 
 import java.time.Duration;
 
+import static org.hamcrest.Matchers.endsWith;
+
 
 public abstract class AbstractConfigurationWithShardingIT extends AbstractConfigurationIT
 {
@@ -15,6 +17,7 @@ public abstract class AbstractConfigurationWithShardingIT extends AbstractConfig
   void testNotFoundForPutMessageToAChatRoomInNotOwnedShard()
   {
     String otherChatRoomId = "4e7246a6-29ae-43ea-b56f-669c3481ac19";
+    int shard = 0;
 
     Awaitility
         .await()
@@ -30,6 +33,9 @@ public abstract class AbstractConfigurationWithShardingIT extends AbstractConfig
               .accept(MediaType.APPLICATION_JSON)
               .bodyValue("The devil rules route 66")
               .exchange()
-              .expectStatus().isNotFound());
+              .expectStatus().isNotFound()
+              .expectBody()
+              .jsonPath("$.type").value(endsWith("/problem/shard-not-owned"))
+              .jsonPath("$.shard").isEqualTo(shard));
   }
 }
-- 
2.20.1