From 374c45981d676ddca6a3c935539af34e798e5b2a Mon Sep 17 00:00:00 2001 From: Kai Moritz Date: Wed, 20 Mar 2024 09:57:15 +0100 Subject: [PATCH] fix: ShardNotOwnedException must map to "503 - Service Unavailable" --- .../kafka/chat/backend/api/ChatBackendControllerAdvice.java | 2 +- .../kafka/chat/backend/AbstractConfigurationWithShardingIT.java | 2 +- .../juplo/kafka/chat/backend/api/ChatBackendControllerTest.java | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/java/de/juplo/kafka/chat/backend/api/ChatBackendControllerAdvice.java b/src/main/java/de/juplo/kafka/chat/backend/api/ChatBackendControllerAdvice.java index cdcee668..9a9cf903 100644 --- a/src/main/java/de/juplo/kafka/chat/backend/api/ChatBackendControllerAdvice.java +++ b/src/main/java/de/juplo/kafka/chat/backend/api/ChatBackendControllerAdvice.java @@ -57,7 +57,7 @@ public class ChatBackendControllerAdvice ServerWebExchange exchange, UriComponentsBuilder uriComponentsBuilder) { - final HttpStatus status = HttpStatus.NOT_FOUND; + final HttpStatus status = HttpStatus.SERVICE_UNAVAILABLE; ProblemDetail problem = ProblemDetail.forStatus(status); problem.setProperty("timestamp", new Date()); diff --git a/src/test/java/de/juplo/kafka/chat/backend/AbstractConfigurationWithShardingIT.java b/src/test/java/de/juplo/kafka/chat/backend/AbstractConfigurationWithShardingIT.java index 5c9ac13f..f8e475ce 100644 --- a/src/test/java/de/juplo/kafka/chat/backend/AbstractConfigurationWithShardingIT.java +++ b/src/test/java/de/juplo/kafka/chat/backend/AbstractConfigurationWithShardingIT.java @@ -33,7 +33,7 @@ public abstract class AbstractConfigurationWithShardingIT extends AbstractConfig .accept(MediaType.APPLICATION_JSON) .bodyValue("The devil rules route 66") .exchange() - .expectStatus().isNotFound() + .expectStatus().is5xxServerError() .expectBody() .jsonPath("$.type").value(endsWith("/problem/shard-not-owned")) .jsonPath("$.shard").isEqualTo(shard)); diff --git a/src/test/java/de/juplo/kafka/chat/backend/api/ChatBackendControllerTest.java b/src/test/java/de/juplo/kafka/chat/backend/api/ChatBackendControllerTest.java index 01de390c..0b365e2a 100644 --- a/src/test/java/de/juplo/kafka/chat/backend/api/ChatBackendControllerTest.java +++ b/src/test/java/de/juplo/kafka/chat/backend/api/ChatBackendControllerTest.java @@ -376,7 +376,7 @@ public class ChatBackendControllerTest int shard) { responseSpec - .expectStatus().isNotFound() + .expectStatus().is5xxServerError() .expectBody() .jsonPath("$.type").isEqualTo("/problem/shard-not-owned") .jsonPath("$.shard").isEqualTo(shard); -- 2.39.5