From 945c49ae24bd4dbdff0e1492cd8a79873e32ad31 Mon Sep 17 00:00:00 2001
From: Kai Moritz <kai@juplo.de>
Date: Thu, 20 Feb 2025 18:36:13 +0100
Subject: [PATCH] =?utf8?q?`ExampleConsumer`=20=C3=BCber=20Generics=20typis?=
 =?utf8?q?iert?=
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit

---
 README.sh                                          |  2 +-
 build.gradle                                       |  2 +-
 docker/docker-compose.yml                          |  6 +++---
 pom.xml                                            |  2 +-
 .../de/juplo/kafka/ApplicationConfiguration.java   |  4 ++--
 src/main/java/de/juplo/kafka/ExampleConsumer.java  | 14 +++++++-------
 6 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/README.sh b/README.sh
index b46e2350..a7cbb894 100755
--- a/README.sh
+++ b/README.sh
@@ -1,6 +1,6 @@
 #!/bin/bash
 
-IMAGE=juplo/spring-consumer:1.1-SNAPSHOT
+IMAGE=juplo/spring-consumer:1.1-generics-SNAPSHOT
 
 if [ "$1" = "cleanup" ]
 then
diff --git a/build.gradle b/build.gradle
index 73b76a85..e949fad4 100644
--- a/build.gradle
+++ b/build.gradle
@@ -6,7 +6,7 @@ plugins {
 }
 
 group = 'de.juplo.kafka'
-version = '1.0-SNAPSHOT'
+version = '1.1-generics-SNAPSHOT'
 
 java {
 	toolchain {
diff --git a/docker/docker-compose.yml b/docker/docker-compose.yml
index 2de43b8b..b9c252af 100644
--- a/docker/docker-compose.yml
+++ b/docker/docker-compose.yml
@@ -180,7 +180,7 @@ services:
     mem_limit:  100m
 
   consumer:
-    image: juplo/spring-consumer:1.1-SNAPSHOT
+    image: juplo/spring-consumer:1.1-generics-SNAPSHOT
     environment:
       spring.kafka.bootstrap-servers: kafka:9092
       spring.kafka.client-id: consumer
@@ -189,7 +189,7 @@ services:
       juplo.consumer.topic: test
 
   peter:
-    image: juplo/spring-consumer:1.1-SNAPSHOT
+    image: juplo/spring-consumer:1.1-generics-SNAPSHOT
     environment:
       spring.kafka.bootstrap-servers: kafka:9092
       spring.kafka.client-id: consumer
@@ -198,7 +198,7 @@ services:
       juplo.consumer.topic: test
 
   ute:
-    image: juplo/spring-consumer:1.1-SNAPSHOT
+    image: juplo/spring-consumer:1.1-generics-SNAPSHOT
     environment:
       spring.kafka.bootstrap-servers: kafka:9092
       spring.kafka.client-id: consumer
diff --git a/pom.xml b/pom.xml
index 960303ca..620a9c72 100644
--- a/pom.xml
+++ b/pom.xml
@@ -15,7 +15,7 @@
   <artifactId>spring-consumer</artifactId>
   <name>Spring Consumer</name>
   <description>Super Simple Consumer-Group, that is implemented as Spring-Boot application and configured by Spring Kafka</description>
-  <version>1.0-SNAPSHOT</version>
+  <version>1.1-generics-SNAPSHOT</version>
 
   <properties>
     <java.version>21</java.version>
diff --git a/src/main/java/de/juplo/kafka/ApplicationConfiguration.java b/src/main/java/de/juplo/kafka/ApplicationConfiguration.java
index 4ea8eee4..efd5e3b9 100644
--- a/src/main/java/de/juplo/kafka/ApplicationConfiguration.java
+++ b/src/main/java/de/juplo/kafka/ApplicationConfiguration.java
@@ -14,7 +14,7 @@ import org.springframework.kafka.core.ConsumerFactory;
 public class ApplicationConfiguration
 {
   @Bean
-  public ExampleConsumer exampleConsumer(
+  public ExampleConsumer<String, String> exampleConsumer(
     Consumer<String, String> kafkaConsumer,
     ApplicationProperties properties,
     KafkaProperties kafkaProperties,
@@ -22,7 +22,7 @@ public class ApplicationConfiguration
   {
     return
       new ExampleConsumer<>(
-        kafkaProperties.getClientId(),
+        properties.getClientId(),
         properties.getConsumerProperties().getTopic(),
         kafkaConsumer,
         () -> applicationContext.close());
diff --git a/src/main/java/de/juplo/kafka/ExampleConsumer.java b/src/main/java/de/juplo/kafka/ExampleConsumer.java
index 1f5a5706..101abd1c 100644
--- a/src/main/java/de/juplo/kafka/ExampleConsumer.java
+++ b/src/main/java/de/juplo/kafka/ExampleConsumer.java
@@ -11,11 +11,11 @@ import java.util.Arrays;
 
 
 @Slf4j
-public class ExampleConsumer implements Runnable
+public class ExampleConsumer<K, V> implements Runnable
 {
   private final String id;
   private final String topic;
-  private final Consumer<String, String> consumer;
+  private final Consumer<K, V> consumer;
   private final Thread workerThread;
   private final Runnable closeCallback;
 
@@ -25,7 +25,7 @@ public class ExampleConsumer implements Runnable
   public ExampleConsumer(
     String clientId,
     String topic,
-    Consumer<String, String> consumer,
+    Consumer<K, V> consumer,
     Runnable closeCallback)
   {
     this.id = clientId;
@@ -49,10 +49,10 @@ public class ExampleConsumer implements Runnable
 
       while (true)
       {
-        ConsumerRecords<String, String> records = consumer.poll(Duration.ofSeconds(1));
+        ConsumerRecords<K, V> records = consumer.poll(Duration.ofSeconds(1));
 
         log.info("{} - Received {} messages", id, records.count());
-        for (ConsumerRecord<String, String> record : records)
+        for (ConsumerRecord<K, V> record : records)
         {
           handleRecord(
             record.topic(),
@@ -86,8 +86,8 @@ public class ExampleConsumer implements Runnable
     String topic,
     Integer partition,
     Long offset,
-    String key,
-    String value)
+    K key,
+    V value)
   {
     consumed++;
     log.info("{} - partition={}-{}, offset={}: {}={}", id, topic, partition, offset, key, value);
-- 
2.39.5