From fb6aa205877a91cc24af68a13f9a2d50555b68ea Mon Sep 17 00:00:00 2001
From: Kai Moritz <kai@juplo.de>
Date: Sun, 18 Feb 2024 17:34:40 +0100
Subject: [PATCH] WIP:callbacks

---
 .../backend/storage/files/FilesStorageStrategy.java    |  8 ++------
 .../storage/mongodb/MongoDbStorageStrategy.java        |  8 +-------
 .../nostorage/NoStorageStorageConfiguration.java       | 10 +---------
 3 files changed, 4 insertions(+), 22 deletions(-)

diff --git a/src/main/java/de/juplo/kafka/chat/backend/storage/files/FilesStorageStrategy.java b/src/main/java/de/juplo/kafka/chat/backend/storage/files/FilesStorageStrategy.java
index 1de0b445..cb7dd31e 100644
--- a/src/main/java/de/juplo/kafka/chat/backend/storage/files/FilesStorageStrategy.java
+++ b/src/main/java/de/juplo/kafka/chat/backend/storage/files/FilesStorageStrategy.java
@@ -121,9 +121,7 @@ public class FilesStorageStrategy implements StorageStrategy
   @Override
   public void writeChatRoomData(
       UUID chatRoomId,
-      Flux<Message> messageFlux,
-      SuccessCallback successCallback,
-      FailureCallback failureCallback)
+      Flux<Message> messageFlux)
   {
     Path path = chatroomPath(chatRoomId);
     log.info("Writing messages for {} to {}", chatRoomId, path);
@@ -174,12 +172,10 @@ public class FilesStorageStrategy implements StorageStrategy
               throw new RuntimeException(e);
             }
           });
-
-      successCallback.accept(chatRoomId);
     }
     catch (IOException e)
     {
-      failureCallback.accept(chatRoomId, e);
+      throw new RuntimeException(e);
     }
   }
 
diff --git a/src/main/java/de/juplo/kafka/chat/backend/storage/mongodb/MongoDbStorageStrategy.java b/src/main/java/de/juplo/kafka/chat/backend/storage/mongodb/MongoDbStorageStrategy.java
index 972122e0..b1bead9b 100644
--- a/src/main/java/de/juplo/kafka/chat/backend/storage/mongodb/MongoDbStorageStrategy.java
+++ b/src/main/java/de/juplo/kafka/chat/backend/storage/mongodb/MongoDbStorageStrategy.java
@@ -41,16 +41,10 @@ public class MongoDbStorageStrategy implements StorageStrategy
   }
 
   @Override
-  public void writeChatRoomData(
-      UUID chatRoomId,
-      Flux<Message> messageFlux,
-      SuccessCallback successCallback,
-      FailureCallback failureCallback)
+  public void writeChatRoomData(UUID chatRoomId, Flux<Message> messageFlux)
   {
     messageFlux
         .map(message -> MessageTo.from(chatRoomId, message))
-        .doOnComplete(() -> successCallback.accept(chatRoomId))
-        .doOnError(throwable -> failureCallback.accept(chatRoomId, throwable))
         .subscribe(messageTo -> messageRepository.save(messageTo));
   }
 
diff --git a/src/main/java/de/juplo/kafka/chat/backend/storage/nostorage/NoStorageStorageConfiguration.java b/src/main/java/de/juplo/kafka/chat/backend/storage/nostorage/NoStorageStorageConfiguration.java
index 376679af..1b20aa37 100644
--- a/src/main/java/de/juplo/kafka/chat/backend/storage/nostorage/NoStorageStorageConfiguration.java
+++ b/src/main/java/de/juplo/kafka/chat/backend/storage/nostorage/NoStorageStorageConfiguration.java
@@ -41,15 +41,7 @@ public class NoStorageStorageConfiguration
       }
 
       @Override
-      public void writeChatRoomData(
-          UUID chatRoomId,
-          Flux<Message> messageFlux,
-          SuccessCallback successCallback,
-          FailureCallback failureCallback
-      )
-      {
-        successCallback.accept(chatRoomId);
-      }
+      public void writeChatRoomData(UUID chatRoomId, Flux<Message> messageFlux) {}
 
       @Override
       public Flux<Message> readChatRoomData(UUID chatRoomId)
-- 
2.20.1