projects
/
demos
/
kafka
/
training
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Rückbau auf einen Consumer, der in `onPartitionsRevoked()` immer committed
[demos/kafka/training]
/
src
/
main
/
java
/
de
/
juplo
/
kafka
/
ApplicationRebalanceListener.java
diff --git
a/src/main/java/de/juplo/kafka/ApplicationRebalanceListener.java
b/src/main/java/de/juplo/kafka/ApplicationRebalanceListener.java
index
63d57df
..
eef0d00
100644
(file)
--- a/
src/main/java/de/juplo/kafka/ApplicationRebalanceListener.java
+++ b/
src/main/java/de/juplo/kafka/ApplicationRebalanceListener.java
@@
-3,6
+3,7
@@
package de.juplo.kafka;
import lombok.RequiredArgsConstructor;
import lombok.extern.slf4j.Slf4j;
import org.apache.kafka.clients.consumer.Consumer;
import lombok.RequiredArgsConstructor;
import lombok.extern.slf4j.Slf4j;
import org.apache.kafka.clients.consumer.Consumer;
+import org.apache.kafka.clients.consumer.ConsumerRebalanceListener;
import org.apache.kafka.common.TopicPartition;
import java.util.*;
import org.apache.kafka.common.TopicPartition;
import java.util.*;
@@
-10,7
+11,7
@@
import java.util.*;
@RequiredArgsConstructor
@Slf4j
@RequiredArgsConstructor
@Slf4j
-public class ApplicationRebalanceListener implements RebalanceListener
+public class ApplicationRebalanceListener implements
Consumer
RebalanceListener
{
private final ApplicationRecordHandler recordHandler;
private final AdderResults adderResults;
{
private final ApplicationRecordHandler recordHandler;
private final AdderResults adderResults;
@@
-20,8
+21,6
@@
public class ApplicationRebalanceListener implements RebalanceListener
private final Set<Integer> partitions = new HashSet<>();
private final Set<Integer> partitions = new HashSet<>();
- private boolean commitsEnabled = true;
-
@Override
public void onPartitionsAssigned(Collection<TopicPartition> partitions)
{
@Override
public void onPartitionsAssigned(Collection<TopicPartition> partitions)
{
@@
-51,17
+50,14
@@
public class ApplicationRebalanceListener implements RebalanceListener
@Override
public void onPartitionsRevoked(Collection<TopicPartition> partitions)
{
@Override
public void onPartitionsRevoked(Collection<TopicPartition> partitions)
{
- if (commitsEnabled)
+ log.info("{} - Commiting offsets for all previously assigned partitions", id);
+ try
{
{
- log.info("{} - Commiting offsets for all previously assigned partitions", id);
- try
- {
- consumer.commitSync();
- }
- catch (Exception e)
- {
- log.warn("{} - Could not commit offsets in onPartitionsRevoked():", id, e);
- }
+ consumer.commitSync();
+ }
+ catch (Exception e)
+ {
+ log.warn("{} - Could not commit offsets in onPartitionsRevoked():", id, e);
}
partitions.forEach(tp ->
}
partitions.forEach(tp ->
@@
-83,16
+79,4
@@
public class ApplicationRebalanceListener implements RebalanceListener
stateRepository.save(new StateDocument(partition, state, results));
});
}
stateRepository.save(new StateDocument(partition, state, results));
});
}
-
- @Override
- public void enableCommits()
- {
- commitsEnabled = true;
- }
-
- @Override
- public void disableCommits()
- {
- commitsEnabled = false;
- }
}
}