projects
/
demos
/
kafka
/
training
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
ROT: Fehler in Test-Logik aufgedeckt
[demos/kafka/training]
/
src
/
test
/
java
/
de
/
juplo
/
kafka
/
GenericApplicationTests.java
diff --git
a/src/test/java/de/juplo/kafka/GenericApplicationTests.java
b/src/test/java/de/juplo/kafka/GenericApplicationTests.java
index
8b9a3ff
..
b0abf37
100644
(file)
--- a/
src/test/java/de/juplo/kafka/GenericApplicationTests.java
+++ b/
src/test/java/de/juplo/kafka/GenericApplicationTests.java
@@
-37,7
+37,7
@@
import static org.awaitility.Awaitility.*;
properties = {
"consumer.bootstrap-server=${spring.embedded.kafka.brokers}",
"consumer.topic=" + TOPIC,
properties = {
"consumer.bootstrap-server=${spring.embedded.kafka.brokers}",
"consumer.topic=" + TOPIC,
- "consumer.commit-interval=
1
s" })
+ "consumer.commit-interval=
500m
s" })
@EmbeddedKafka(topics = TOPIC, partitions = PARTITIONS)
@Slf4j
abstract class GenericApplicationTests<K, V>
@EmbeddedKafka(topics = TOPIC, partitions = PARTITIONS)
@Slf4j
abstract class GenericApplicationTests<K, V>
@@
-78,12
+78,13
@@
abstract class GenericApplicationTests<K, V>
@Test
void commitsCurrentOffsetsOnSuccess()
{
@Test
void commitsCurrentOffsetsOnSuccess()
{
- recordGenerator.generate(100, Set.of(), Set.of(), messageSender);
+ int numberOfGeneratedMessages =
+ recordGenerator.generate(false, false, messageSender);
- await(
"100
records received")
+ await(
numberOfGeneratedMessages + "
records received")
.atMost(Duration.ofSeconds(30))
.pollInterval(Duration.ofSeconds(1))
.atMost(Duration.ofSeconds(30))
.pollInterval(Duration.ofSeconds(1))
- .until(() -> receivedRecords.size() >=
100
);
+ .until(() -> receivedRecords.size() >=
numberOfGeneratedMessages
);
await("Offsets committed")
.atMost(Duration.ofSeconds(10))
await("Offsets committed")
.atMost(Duration.ofSeconds(10))
@@
-97,13
+98,16
@@
abstract class GenericApplicationTests<K, V>
assertThatExceptionOfType(IllegalStateException.class)
.isThrownBy(() -> endlessConsumer.exitStatus())
.describedAs("Consumer should still be running");
assertThatExceptionOfType(IllegalStateException.class)
.isThrownBy(() -> endlessConsumer.exitStatus())
.describedAs("Consumer should still be running");
+
+ recordGenerator.assertBusinessLogic();
}
@Test
@SkipWhenErrorCannotBeGenerated(poisonPill = true)
void commitsOffsetOfErrorForReprocessingOnDeserializationError()
{
}
@Test
@SkipWhenErrorCannotBeGenerated(poisonPill = true)
void commitsOffsetOfErrorForReprocessingOnDeserializationError()
{
- recordGenerator.generate(100, Set.of(77), Set.of(), messageSender);
+ int numberOfGeneratedMessages =
+ recordGenerator.generate(true, false, messageSender);
await("Consumer failed")
.atMost(Duration.ofSeconds(30))
await("Consumer failed")
.atMost(Duration.ofSeconds(30))
@@
-123,7
+127,7
@@
abstract class GenericApplicationTests<K, V>
compareToCommitedOffsets(newOffsets);
assertThat(receivedRecords.size())
.describedAs("Received not all sent events")
compareToCommitedOffsets(newOffsets);
assertThat(receivedRecords.size())
.describedAs("Received not all sent events")
- .isLessThan(
100
);
+ .isLessThan(
numberOfGeneratedMessages
);
assertThatNoException()
.describedAs("Consumer should not be running")
assertThatNoException()
.describedAs("Consumer should not be running")
@@
-131,13
+135,16
@@
abstract class GenericApplicationTests<K, V>
assertThat(endlessConsumer.exitStatus())
.describedAs("Consumer should have exited abnormally")
.containsInstanceOf(RecordDeserializationException.class);
assertThat(endlessConsumer.exitStatus())
.describedAs("Consumer should have exited abnormally")
.containsInstanceOf(RecordDeserializationException.class);
+
+ recordGenerator.assertBusinessLogic();
}
@Test
@SkipWhenErrorCannotBeGenerated(logicError = true)
void doesNotCommitOffsetsOnLogicError()
{
}
@Test
@SkipWhenErrorCannotBeGenerated(logicError = true)
void doesNotCommitOffsetsOnLogicError()
{
- recordGenerator.generate(100, Set.of(), Set.of(77), messageSender);
+ int numberOfGeneratedMessages =
+ recordGenerator.generate(false, true, messageSender);
await("Consumer failed")
.atMost(Duration.ofSeconds(30))
await("Consumer failed")
.atMost(Duration.ofSeconds(30))
@@
-157,7
+164,7
@@
abstract class GenericApplicationTests<K, V>
compareToCommitedOffsets(oldOffsets);
assertThat(receivedRecords.size())
.describedAs("Received not all sent events")
compareToCommitedOffsets(oldOffsets);
assertThat(receivedRecords.size())
.describedAs("Received not all sent events")
- .isLessThan(
100
);
+ .isLessThan(
numberOfGeneratedMessages
);
assertThatNoException()
.describedAs("Consumer should not be running")
assertThatNoException()
.describedAs("Consumer should not be running")
@@
-165,6
+172,8
@@
abstract class GenericApplicationTests<K, V>
assertThat(endlessConsumer.exitStatus())
.describedAs("Consumer should have exited abnormally")
.containsInstanceOf(RuntimeException.class);
assertThat(endlessConsumer.exitStatus())
.describedAs("Consumer should have exited abnormally")
.containsInstanceOf(RuntimeException.class);
+
+ recordGenerator.assertBusinessLogic();
}
}
@@
-238,13
+247,12
@@
abstract class GenericApplicationTests<K, V>
public interface RecordGenerator
{
public interface RecordGenerator
{
- void generate(
- int numberOfMessagesToGenerate,
- Set<Integer> poisonPills,
- Set<Integer> logicErrors,
+ int generate(
+ boolean poisonPills,
+ boolean logicErrors,
Consumer<ProducerRecord<Bytes, Bytes>> messageSender);
Consumer<ProducerRecord<Bytes, Bytes>> messageSender);
- default boolean canGeneratePois
i
onPill()
+ default boolean canGeneratePoisonPill()
{
return true;
}
{
return true;
}
@@
-253,6
+261,11
@@
abstract class GenericApplicationTests<K, V>
{
return true;
}
{
return true;
}
+
+ default void assertBusinessLogic()
+ {
+ log.debug("No business-logic to assert");
+ }
}
void sendMessage(ProducerRecord<Bytes, Bytes> record)
}
void sendMessage(ProducerRecord<Bytes, Bytes> record)