ROT: Verbesserungen aus 'deserialization' in 'sumup-adder' gemerged

[demos/kafka/training] / src / test / java / de / juplo / kafka / AdderBusinessLogicTest.java

diff --git a/src/test/java/de/juplo/kafka/AdderBusinessLogicTest.java b/src/test/java/de/juplo/kafka/AdderBusinessLogicTest.java
index 6f114d2..435f036 100644 (file)
--- a/src/test/java/de/juplo/kafka/AdderBusinessLogicTest.java
+++ b/src/test/java/de/juplo/kafka/AdderBusinessLogicTest.java
@@ -18,7 +18,7 @@ public class AdderBusinessLogicTest
 {
   @Test
   @DisplayName("A new sum can be started, if it does not exist")
-  public void testCanStartSumIfNotExists()
+  public void testStartSumPossibleIfNotExists()
   {
     AdderBusinessLogic adder = new AdderBusinessLogic();
     assertThatNoException().isThrownBy(() -> adder.startSum("foo"));
@@ -35,7 +35,7 @@ public class AdderBusinessLogicTest
 
   @Test
   @DisplayName("An empty Optional should be returned, for a non-existing sum")
-  public void testEmptyOptionalForNonExistingSum()
+  public void testGetSumReturnsEmptyOptionalForNonExistingSum()
   {
     AdderBusinessLogic adder = new AdderBusinessLogic();
     assertThat(adder.getSum("foo")).isEmpty();
@@ -43,7 +43,7 @@ public class AdderBusinessLogicTest
 
   @Test
   @DisplayName("A non-empty Optional should be returned, for an existing sum")
-  public void testNonEmptyOptionalForExistingSum()
+  public void testGetSumReturnsNonEmptyOptionalForExistingSum()
   {
     AdderBusinessLogic adder = new AdderBusinessLogic();
     adder.startSum("foo");
@@ -52,13 +52,23 @@ public class AdderBusinessLogicTest
 
   @Test
   @DisplayName("A sum can be ended, if it does exist")
-  public void testCanEndIfSumExists()
+  public void testEndSumPossibleIfSumExists()
   {
     AdderBusinessLogic adder = new AdderBusinessLogic();
     adder.startSum("foo");
     assertThatNoException().isThrownBy(() -> adder.endSum("foo"));
   }
 
+  @Test
+  @DisplayName("An existing sum is removed, if ended")
+  public void testEndSumRemovesSumIfSumExists()
+  {
+    AdderBusinessLogic adder = new AdderBusinessLogic();
+    adder.startSum("foo");
+    adder.endSum("foo");
+    assertThat(adder.getSum("foo")).isEmpty();
+  }
+
   @Test
   @DisplayName("An existing Sum returns a non-null value, if ended")
   public void testEndSumReturnsNonNullValueIfSumExists()
@@ -95,7 +105,7 @@ public class AdderBusinessLogicTest
 
   @Test
   @DisplayName("Adding a null-value to an existing sum causes an IllegalArgumentException")
-  public void testAddNullToExistingSumCausesException()
+  public void testAddSumWithNullValueToExistingSumCausesException()
   {
     AdderBusinessLogic adder = new AdderBusinessLogic();
     adder.startSum("foo");
@@ -105,7 +115,7 @@ public class AdderBusinessLogicTest
   @ParameterizedTest(name = "{index}: Adding {0}")
   @DisplayName("Adding a non-positive value to an existing sum causes an IllegalArgumentException")
   @ValueSource(ints = { 0, -1, -6, -66, Integer.MIN_VALUE })
-  public void testAddingNonPositiveValueToExistingSumCausesException(int value)
+  public void testAddSumWithNonPositiveValueToExistingSumCausesException(int value)
   {
     AdderBusinessLogic adder = new AdderBusinessLogic();
     adder.startSum("foo");
@@ -114,7 +124,7 @@ public class AdderBusinessLogicTest
 
   @Test
   @DisplayName("Can add a positive value to an existing sum")
-  public void testCanAddPositiveValueToExistingSum()
+  public void testAddSumWithPositiveValuePossibleIfSumExists()
   {
     AdderBusinessLogic adder = new AdderBusinessLogic();
     adder.startSum("foo");
@@ -124,7 +134,7 @@ public class AdderBusinessLogicTest
   @ParameterizedTest(name = "{index}: Summing up {0}")
   @DisplayName("Adds up numbers correctly")
   @MethodSource("numbersProvider")
-  public void testCanAddPositiveValueToExistingSum(int... numbers)
+  public void testAddSumAddsUpNumbersCorrectlyIfSumExists(int... numbers)
   {
     long expectedResult = Arrays.stream(numbers).sum();
     AdderBusinessLogic adder = new AdderBusinessLogic();