properties = {
"consumer.bootstrap-server=${spring.embedded.kafka.brokers}",
"consumer.topic=" + TOPIC,
- "consumer.commit-interval=1s" })
+ "consumer.commit-interval=500ms" })
@EmbeddedKafka(topics = TOPIC, partitions = PARTITIONS)
@Slf4j
abstract class GenericApplicationTests<K, V>
KafkaConsumer<Bytes, Bytes> offsetConsumer;
EndlessConsumer<K, V> endlessConsumer;
Map<TopicPartition, Long> oldOffsets;
- Map<TopicPartition, Long> newOffsets;
+ Map<TopicPartition, Long> seenOffsets;
Set<ConsumerRecord<K, V>> receivedRecords;
@Test
void commitsCurrentOffsetsOnSuccess()
{
- recordGenerator.generate(100, Set.of(), Set.of(), messageSender);
+ int numberOfGeneratedMessages =
+ recordGenerator.generate(false, false, messageSender);
- await("100 records received")
+ await(numberOfGeneratedMessages + " records received")
.atMost(Duration.ofSeconds(30))
.pollInterval(Duration.ofSeconds(1))
- .until(() -> receivedRecords.size() >= 100);
+ .until(() -> receivedRecords.size() >= numberOfGeneratedMessages);
await("Offsets committed")
.atMost(Duration.ofSeconds(10))
.untilAsserted(() ->
{
checkSeenOffsetsForProgress();
- compareToCommitedOffsets(newOffsets);
+ assertSeenOffsetsEqualCommittedOffsets(seenOffsets);
});
assertThatExceptionOfType(IllegalStateException.class)
.isThrownBy(() -> endlessConsumer.exitStatus())
.describedAs("Consumer should still be running");
+
+ recordGenerator.assertBusinessLogic();
}
@Test
@SkipWhenErrorCannotBeGenerated(poisonPill = true)
void commitsOffsetOfErrorForReprocessingOnDeserializationError()
{
- recordGenerator.generate(100, Set.of(77), Set.of(), messageSender);
+ int numberOfGeneratedMessages =
+ recordGenerator.generate(true, false, messageSender);
await("Consumer failed")
.atMost(Duration.ofSeconds(30))
.until(() -> !endlessConsumer.running());
checkSeenOffsetsForProgress();
- compareToCommitedOffsets(newOffsets);
+ assertSeenOffsetsEqualCommittedOffsets(seenOffsets);
endlessConsumer.start();
await("Consumer failed")
.until(() -> !endlessConsumer.running());
checkSeenOffsetsForProgress();
- compareToCommitedOffsets(newOffsets);
+ assertSeenOffsetsEqualCommittedOffsets(seenOffsets);
assertThat(receivedRecords.size())
.describedAs("Received not all sent events")
- .isLessThan(100);
+ .isLessThan(numberOfGeneratedMessages);
assertThatNoException()
.describedAs("Consumer should not be running")
assertThat(endlessConsumer.exitStatus())
.describedAs("Consumer should have exited abnormally")
.containsInstanceOf(RecordDeserializationException.class);
+
+ recordGenerator.assertBusinessLogic();
}
@Test
@SkipWhenErrorCannotBeGenerated(logicError = true)
void doesNotCommitOffsetsOnLogicError()
{
- recordGenerator.generate(100, Set.of(), Set.of(77), messageSender);
+ int numberOfGeneratedMessages =
+ recordGenerator.generate(false, true, messageSender);
await("Consumer failed")
.atMost(Duration.ofSeconds(30))
.until(() -> !endlessConsumer.running());
checkSeenOffsetsForProgress();
- compareToCommitedOffsets(oldOffsets);
+ assertSeenOffsetsAreBehindCommittedOffsets(seenOffsets);
endlessConsumer.start();
await("Consumer failed")
.pollInterval(Duration.ofSeconds(1))
.until(() -> !endlessConsumer.running());
- checkSeenOffsetsForProgress();
- compareToCommitedOffsets(oldOffsets);
- assertThat(receivedRecords.size())
- .describedAs("Received not all sent events")
- .isLessThan(100);
+ assertSeenOffsetsAreBehindCommittedOffsets(seenOffsets);
assertThatNoException()
.describedAs("Consumer should not be running")
assertThat(endlessConsumer.exitStatus())
.describedAs("Consumer should have exited abnormally")
.containsInstanceOf(RuntimeException.class);
+
+ recordGenerator.assertBusinessLogic();
}
/** Helper methods for the verification of expectations */
- void compareToCommitedOffsets(Map<TopicPartition, Long> offsetsToCheck)
+ void assertSeenOffsetsEqualCommittedOffsets(Map<TopicPartition, Long> offsetsToCheck)
{
doForCurrentOffsets((tp, offset) ->
{
Long expected = offsetsToCheck.get(tp) + 1;
- log.debug("Checking, if the offset for {} is {}", tp, expected);
+ log.debug("Checking, if the offset {} for {} is exactly {}", offset, tp, expected);
assertThat(offset)
.describedAs("Committed offset corresponds to the offset of the consumer")
.isEqualTo(expected);
});
}
+ void assertSeenOffsetsAreBehindCommittedOffsets(Map<TopicPartition, Long> offsetsToCheck)
+ {
+ List<Boolean> isOffsetBehindSeen = new LinkedList<>();
+
+ doForCurrentOffsets((tp, offset) ->
+ {
+ Long expected = offsetsToCheck.get(tp) + 1;
+ log.debug("Checking, if the offset {} for {} is at most {}", offset, tp, expected);
+ assertThat(offset)
+ .describedAs("Committed offset corresponds to the offset of the consumer")
+ .isLessThanOrEqualTo(expected);
+ isOffsetBehindSeen.add(offset < expected);
+ });
+
+ assertThat(isOffsetBehindSeen.stream().reduce(false, (result, next) -> result | next))
+ .describedAs("Committed offsets are behind seen offsets")
+ .isTrue();
+ }
+
void checkSeenOffsetsForProgress()
{
// Be sure, that some messages were consumed...!
partitions().forEach(tp ->
{
Long oldOffset = oldOffsets.get(tp) + 1;
- Long newOffset = newOffsets.get(tp) + 1;
+ Long newOffset = seenOffsets.get(tp) + 1;
if (!oldOffset.equals(newOffset))
{
log.debug("Progress for {}: {} -> {}", tp, oldOffset, newOffset);
public interface RecordGenerator
{
- void generate(
- int numberOfMessagesToGenerate,
- Set<Integer> poisonPills,
- Set<Integer> logicErrors,
+ int generate(
+ boolean poisonPills,
+ boolean logicErrors,
Consumer<ProducerRecord<Bytes, Bytes>> messageSender);
- default boolean canGeneratePoisionPill()
+ default boolean canGeneratePoisonPill()
{
return true;
}
{
return true;
}
+
+ default void assertBusinessLogic()
+ {
+ log.debug("No business-logic to assert");
+ }
}
void sendMessage(ProducerRecord<Bytes, Bytes> record)
seekToEnd();
oldOffsets = new HashMap<>();
- newOffsets = new HashMap<>();
+ seenOffsets = new HashMap<>();
receivedRecords = new HashSet<>();
doForCurrentOffsets((tp, offset) ->
{
oldOffsets.put(tp, offset - 1);
- newOffsets.put(tp, offset - 1);
+ seenOffsets.put(tp, offset - 1);
});
Consumer<ConsumerRecord<K, V>> captureOffsetAndExecuteTestHandler =
record ->
{
- newOffsets.put(
+ seenOffsets.put(
new TopicPartition(record.topic(), record.partition()),
record.offset());
receivedRecords.add(record);