package de.juplo.kafka.chat.backend.api;
+import de.juplo.kafka.chat.backend.ChatBackendProperties;
import de.juplo.kafka.chat.backend.domain.*;
+import de.juplo.kafka.chat.backend.persistence.inmemory.InMemoryChatHomeService;
+import de.juplo.kafka.chat.backend.persistence.inmemory.ShardingStrategy;
import lombok.extern.slf4j.Slf4j;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;
import java.time.Clock;
import java.time.LocalDateTime;
+import java.util.Set;
import java.util.UUID;
+import java.util.stream.Collectors;
+import java.util.stream.IntStream;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.Mockito.*;
-@SpringBootTest(properties = "spring.main.allow-bean-definition-overriding=true")
+@SpringBootTest(properties = {
+ "spring.main.allow-bean-definition-overriding=true",
+ "chat.backend.inmemory.sharding-strategy=kafkalike",
+ "chat.backend.inmemory.num-shards=10",
+ "chat.backend.inmemory.owned-shards=6",
+ })
@AutoConfigureWebTestClient
@Slf4j
public class ChatBackendControllerTest
{
+ @Autowired
+ ChatBackendProperties properties;
+ @Autowired
+ ShardingStrategy shardingStrategy;
+
@MockBean
- ChatHomeService chatHomeService;
+ InMemoryChatHomeService chatHomeService;
@MockBean
ChatRoomService chatRoomService;
void testUnknownChatroomExceptionForListChatroom(@Autowired WebTestClient client)
{
// Given
- UUID chatroomId = UUID.randomUUID();
- when(chatHomeService.getChatRoom(any(UUID.class))).thenReturn(Mono.empty());
+ UUID chatroomId = getRandomIdForOwnedShard();
+ when(chatHomeService.getChatRoom(anyInt(), any(UUID.class))).thenReturn(Mono.empty());
+ when(chatHomeService.getOwnedShards()).thenReturn(new int[] { 6 });
// When
WebTestClient.ResponseSpec responseSpec = client
.get()
- .uri("/list/{chatroomId}", chatroomId)
+ .uri("/{chatroomId}/list", chatroomId)
.accept(MediaType.APPLICATION_JSON)
.exchange();
void testUnknownChatroomExceptionForGetChatroom(@Autowired WebTestClient client)
{
// Given
- UUID chatroomId = UUID.randomUUID();
- when(chatHomeService.getChatRoom(any(UUID.class))).thenReturn(Mono.empty());
+ UUID chatroomId = getRandomIdForOwnedShard();
+ when(chatHomeService.getChatRoom(anyInt(), any(UUID.class))).thenReturn(Mono.empty());
+ when(chatHomeService.getOwnedShards()).thenReturn(new int[] { 6 });
// When
WebTestClient.ResponseSpec responseSpec = client
.get()
- .uri("/get/{chatroomId}", chatroomId)
+ .uri("/{chatroomId}", chatroomId)
.accept(MediaType.APPLICATION_JSON)
.exchange();
void testUnknownChatroomExceptionForPutMessage(@Autowired WebTestClient client)
{
// Given
- UUID chatroomId = UUID.randomUUID();
+ UUID chatroomId = getRandomIdForOwnedShard();
String username = "foo";
Long messageId = 66l;
- when(chatHomeService.getChatRoom(any(UUID.class))).thenReturn(Mono.empty());
+ when(chatHomeService.getChatRoom(anyInt(), any(UUID.class))).thenReturn(Mono.empty());
+ when(chatHomeService.getOwnedShards()).thenReturn(new int[] { 6 });
// When
WebTestClient.ResponseSpec responseSpec = client
.put()
.uri(
- "/put/{chatroomId}/{username}/{messageId}",
+ "/{chatroomId}/{username}/{messageId}",
chatroomId,
username,
messageId)
void testUnknownChatroomExceptionForGetMessage(@Autowired WebTestClient client)
{
// Given
- UUID chatroomId = UUID.randomUUID();
+ UUID chatroomId = getRandomIdForOwnedShard();
String username = "foo";
Long messageId = 66l;
- when(chatHomeService.getChatRoom(any(UUID.class))).thenReturn(Mono.empty());
+ when(chatHomeService.getChatRoom(anyInt(), any(UUID.class))).thenReturn(Mono.empty());
+ when(chatHomeService.getOwnedShards()).thenReturn(new int[] { 6 });
// When
WebTestClient.ResponseSpec responseSpec = client
.get()
.uri(
- "/get/{chatroomId}/{username}/{messageId}",
+ "/{chatroomId}/{username}/{messageId}",
chatroomId,
username,
messageId)
void testUnknownChatroomExceptionForListenChatroom(@Autowired WebTestClient client)
{
// Given
- UUID chatroomId = UUID.randomUUID();
- when(chatHomeService.getChatRoom(any(UUID.class))).thenReturn(Mono.empty());
+ UUID chatroomId = getRandomIdForOwnedShard();
+ when(chatHomeService.getChatRoom(anyInt(), any(UUID.class))).thenReturn(Mono.empty());
+ when(chatHomeService.getOwnedShards()).thenReturn(new int[] { 6 });
// When
WebTestClient.ResponseSpec responseSpec = client
.get()
- .uri("/listen/{chatroomId}", chatroomId)
+ .uri("/{chatroomId}/listen", chatroomId)
// .accept(MediaType.TEXT_EVENT_STREAM, MediaType.APPLICATION_JSON) << TODO: Does not work!
.exchange();
@Test
@DisplayName("Assert expected problem-details for message mutation on PUT /put/{chatroomId}/{username}/{messageId}")
- void testMessageMutationException(@Autowired WebTestClient client) throws Exception
+ void testMessageMutationException(@Autowired WebTestClient client)
{
// Given
- UUID chatroomId = UUID.randomUUID();
+ UUID chatroomId = getRandomIdForOwnedShard();
String user = "foo";
Long messageId = 66l;
Message.MessageKey key = Message.MessageKey.of(user, messageId);
ChatRoom chatRoom = new ChatRoom(
chatroomId,
"Test-ChatRoom",
+ 0,
Clock.systemDefaultZone(),
chatRoomService, 8);
- when(chatHomeService.getChatRoom(any(UUID.class))).thenReturn(Mono.just(chatRoom));
+ when(chatHomeService.getChatRoom(anyInt(), any(UUID.class))).thenReturn(Mono.just(chatRoom));
Message existingMessage = new Message(
key,
serialNumberExistingMessage,
.thenReturn(Mono.just(existingMessage));
// Needed for readable error-reports, in case of a bug that leads to according unwanted call
when(chatRoomService.persistMessage(any(Message.MessageKey.class), any(LocalDateTime.class), any(String.class)))
- .thenReturn(mock(Message.class));
+ .thenReturn(Mono.just(mock(Message.class)));
// When
client
.put()
.uri(
- "/put/{chatroomId}/{username}/{messageId}",
+ "/{chatroomId}/{username}/{messageId}",
chatroomId,
user,
messageId)
.jsonPath("$.mutatedText").isEqualTo(textMutatedMessage);
verify(chatRoomService, never()).persistMessage(eq(key), any(LocalDateTime.class), any(String.class));
}
+
+ @Test
+ @DisplayName("Assert expected problem-details for invalid username on PUT /put/{chatroomId}/{username}/{messageId}")
+ void testInvalidUsernameException(@Autowired WebTestClient client)
+ {
+ // Given
+ UUID chatroomId = getRandomIdForOwnedShard();
+ String user = "Foo";
+ Long messageId = 66l;
+ Message.MessageKey key = Message.MessageKey.of(user, messageId);
+ String textMessage = "Hallo Welt";
+ ChatRoom chatRoom = new ChatRoom(
+ chatroomId,
+ "Test-ChatRoom",
+ 0,
+ Clock.systemDefaultZone(),
+ chatRoomService, 8);
+ when(chatHomeService.getChatRoom(anyInt(), any(UUID.class)))
+ .thenReturn(Mono.just(chatRoom));
+ when(chatRoomService.getMessage(any(Message.MessageKey.class)))
+ .thenReturn(Mono.empty());
+ // Needed for readable error-reports, in case of a bug that leads to according unwanted call
+ when(chatRoomService.persistMessage(any(Message.MessageKey.class), any(LocalDateTime.class), any(String.class)))
+ .thenReturn(Mono.just(mock(Message.class)));
+
+ // When
+ client
+ .put()
+ .uri(
+ "/{chatroomId}/{username}/{messageId}",
+ chatroomId,
+ user,
+ messageId)
+ .bodyValue(textMessage)
+ .accept(MediaType.APPLICATION_JSON)
+ .exchange()
+ // Then
+ .expectStatus().is4xxClientError()
+ .expectBody()
+ .jsonPath("$.type").isEqualTo("/problem/invalid-username")
+ .jsonPath("$.username").isEqualTo(user);
+ verify(chatRoomService, never()).persistMessage(eq(key), any(LocalDateTime.class), any(String.class));
+ }
+
+ @Test
+ @DisplayName("Assert expected problem-details for not owned shard on GET /{chatroomId}")
+ void testShardNotOwnedExceptionForGetChatroom(@Autowired WebTestClient client)
+ {
+ // Given
+ UUID chatroomId = getRandomIdForForeignShard();
+
+ // When
+ WebTestClient.ResponseSpec responseSpec = client
+ .get()
+ .uri("/{chatroomId}", chatroomId)
+ .accept(MediaType.APPLICATION_JSON)
+ .exchange();
+
+ // Then
+ assertProblemDetailsForShardNotOwnedException(responseSpec, shardingStrategy.selectShard(chatroomId));
+ }
+
+ @Test
+ @DisplayName("Assert expected problem-details for not owned shard on GET /list/{chatroomId}")
+ void testShardNotOwnedExceptionForListChatroom(@Autowired WebTestClient client)
+ {
+ // Given
+ UUID chatroomId = getRandomIdForForeignShard();
+
+ // When
+ WebTestClient.ResponseSpec responseSpec = client
+ .get()
+ .uri("/{chatroomId}/list", chatroomId)
+ .accept(MediaType.APPLICATION_JSON)
+ .exchange();
+
+ // Then
+ assertProblemDetailsForShardNotOwnedException(responseSpec, shardingStrategy.selectShard(chatroomId));
+ }
+
+ @Test
+ @DisplayName("Assert expected problem-details for now owned shard on PUT /put/{chatroomId}/{username}/{messageId}")
+ void testShardNotOwnedExceptionForPutMessage(@Autowired WebTestClient client)
+ {
+ // Given
+ UUID chatroomId = getRandomIdForForeignShard();
+ String username = "foo";
+ Long messageId = 66l;
+ when(chatHomeService.getChatRoom(anyInt(), any(UUID.class))).thenReturn(Mono.empty());
+
+ // When
+ WebTestClient.ResponseSpec responseSpec = client
+ .put()
+ .uri(
+ "/{chatroomId}/{username}/{messageId}",
+ chatroomId,
+ username,
+ messageId)
+ .bodyValue("bar")
+ .accept(MediaType.APPLICATION_JSON)
+ .exchange();
+
+ // Then
+ assertProblemDetailsForShardNotOwnedException(responseSpec, shardingStrategy.selectShard(chatroomId));
+ }
+
+ @Test
+ @DisplayName("Assert expected problem-details for not owned shard on GET /get/{chatroomId}/{username}/{messageId}")
+ void testShardNotOwnedExceptionForGetMessage(@Autowired WebTestClient client)
+ {
+ // Given
+ UUID chatroomId = getRandomIdForForeignShard();
+ String username = "foo";
+ Long messageId = 66l;
+ when(chatHomeService.getChatRoom(anyInt(), any(UUID.class))).thenReturn(Mono.empty());
+
+ // When
+ WebTestClient.ResponseSpec responseSpec = client
+ .get()
+ .uri(
+ "/{chatroomId}/{username}/{messageId}",
+ chatroomId,
+ username,
+ messageId)
+ .accept(MediaType.APPLICATION_JSON)
+ .exchange();
+
+ // Then
+ assertProblemDetailsForShardNotOwnedException(responseSpec, shardingStrategy.selectShard(chatroomId));
+ }
+
+ @Test
+ @DisplayName("Assert expected problem-details for not owned shard on GET /listen/{chatroomId}")
+ void testShardNotOwnedExceptionForListenChatroom(@Autowired WebTestClient client)
+ {
+ // Given
+ UUID chatroomId = getRandomIdForForeignShard();
+ when(chatHomeService.getChatRoom(anyInt(), any(UUID.class))).thenReturn(Mono.empty());
+
+ // When
+ WebTestClient.ResponseSpec responseSpec = client
+ .get()
+ .uri("/{chatroomId}/listen", chatroomId)
+ // .accept(MediaType.TEXT_EVENT_STREAM, MediaType.APPLICATION_JSON) << TODO: Does not work!
+ .exchange();
+
+ // Then
+ assertProblemDetailsForShardNotOwnedException(responseSpec, shardingStrategy.selectShard(chatroomId));
+ }
+
+ private void assertProblemDetailsForShardNotOwnedException(
+ WebTestClient.ResponseSpec responseSpec,
+ int shard)
+ {
+ responseSpec
+ .expectStatus().isNotFound()
+ .expectBody()
+ .jsonPath("$.type").isEqualTo("/problem/shard-not-owned")
+ .jsonPath("$.shard").isEqualTo(shard);
+ }
+
+ private UUID getRandomIdForOwnedShard()
+ {
+ Set<Integer> ownedShards = ownedShards();
+ UUID randomId;
+
+ do
+ {
+ randomId = UUID.randomUUID();
+ }
+ while (!ownedShards.contains(shardingStrategy.selectShard(randomId)));
+
+ return randomId;
+ }
+
+ private UUID getRandomIdForForeignShard()
+ {
+ Set<Integer> ownedShards = ownedShards();
+ UUID randomId;
+
+ do
+ {
+ randomId = UUID.randomUUID();
+ }
+ while (ownedShards.contains(shardingStrategy.selectShard(randomId)));
+
+ return randomId;
+ }
+
+ private Set<Integer> ownedShards()
+ {
+ return IntStream
+ .of(properties.getInmemory().getOwnedShards())
+ .mapToObj(shard -> Integer.valueOf(shard))
+ .collect(Collectors.toSet());
+ }
}
projects / demos / kafka / chat / blobdiff