X-Git-Url: https://juplo.de/gitweb/?a=blobdiff_plain;f=src%2Ftest%2Fjava%2Fde%2Fjuplo%2Fkafka%2FApplicationTests.java;h=61e0a8d148ea52fd6936f68ca65b38f4818610f8;hb=438f39fa648862a423ba29b950ba58f3043075c3;hp=e35b223666e6b1519292f513f5cd9280b1f5278c;hpb=2939f4b7bae23df34968ce3d87be1b83cf0fba90;p=demos%2Fkafka%2Ftraining

diff --git a/src/test/java/de/juplo/kafka/ApplicationTests.java b/src/test/java/de/juplo/kafka/ApplicationTests.java
index e35b223..61e0a8d 100644
--- a/src/test/java/de/juplo/kafka/ApplicationTests.java
+++ b/src/test/java/de/juplo/kafka/ApplicationTests.java
@@ -82,6 +82,8 @@ class ApplicationTests
 		Set<ConsumerRecord<String, Long>> received = new HashSet<>();
 		testHandler = record -> received.add(record);
 
+		endlessConsumer.start();
+
 		await("100 records received")
 				.atMost(Duration.ofSeconds(30))
 				.until(() -> received.size() >= 100);
@@ -97,19 +99,35 @@ class ApplicationTests
 
 	@Test
 	@Order(2)
-	void commitsNoOffsetsOnError()
+	void commitsOffsetOfErrorForReprocessingOnError()
 	{
 		send100Messages(counter ->
 				counter == 77
 						? new Bytes(stringSerializer.serialize(TOPIC, "BOOM!"))
 						: new Bytes(longSerializer.serialize(TOPIC, counter)));
 
+		Set<ConsumerRecord<String, Long>> received = new HashSet<>();
+		testHandler = record -> received.add(record);
+
+		endlessConsumer.start();
+
+		await("Consumer failed")
+				.atMost(Duration.ofSeconds(30))
+				.until(() -> !endlessConsumer.running());
+
+		checkSeenOffsetsForProgress();
+		compareToCommitedOffsets(newOffsets);
+
+		endlessConsumer.start();
 		await("Consumer failed")
 				.atMost(Duration.ofSeconds(30))
 				.until(() -> !endlessConsumer.running());
 
 		checkSeenOffsetsForProgress();
-		compareToCommitedOffsets(oldOffsets);
+		compareToCommitedOffsets(newOffsets);
+		assertThat(received.size())
+				.describedAs("Received not all sent events")
+				.isLessThan(100);
 	}
 
 
@@ -121,7 +139,9 @@ class ApplicationTests
 		{
 			Long expected = offsetsToCheck.get(tp) + 1;
 			log.debug("Checking, if the offset for {} is {}", tp, expected);
-			assertThat(offset).isEqualTo(expected);
+			assertThat(offset)
+					.describedAs("Committed offset corresponds to the offset of the consumer")
+					.isEqualTo(expected);
 		});
 	}
 
@@ -139,7 +159,9 @@ class ApplicationTests
 				withProgress.add(tp);
 			}
 		});
-		assertThat(withProgress).isNotEmpty().describedAs("Found no partitions with any offset-progress");
+		assertThat(withProgress)
+				.describedAs("Some offsets must have changed, compared to the old offset-positions")
+				.isNotEmpty();
 	}
 
 
@@ -234,8 +256,6 @@ class ApplicationTests
 						properties.getTopic(),
 						kafkaConsumer,
 						captureOffsetAndExecuteTestHandler);
-
-		endlessConsumer.start();
 	}
 
 	@AfterEach