From: Kai Moritz <kai@juplo.de>
Date: Sat, 13 Aug 2022 13:24:16 +0000 (+0200)
Subject: ROT: Erwartungen an SumBusinessLogic.getSum(String)
X-Git-Url: https://juplo.de/gitweb/?a=commitdiff_plain;ds=sidebyside;h=614ab1f07d1cae49c06b8bcbd6132e0aa5827246;p=demos%2Fkafka%2Ftraining

ROT: Erwartungen an SumBusinessLogic.getSum(String)
---

diff --git a/src/main/java/de/juplo/kafka/SumBusinessLogic.java b/src/main/java/de/juplo/kafka/SumBusinessLogic.java
index e662606..5cb906a 100644
--- a/src/main/java/de/juplo/kafka/SumBusinessLogic.java
+++ b/src/main/java/de/juplo/kafka/SumBusinessLogic.java
@@ -2,6 +2,7 @@ package de.juplo.kafka;
 
 import java.util.HashMap;
 import java.util.Map;
+import java.util.Optional;
 
 
 public class SumBusinessLogic
@@ -27,4 +28,9 @@ public class SumBusinessLogic
 
     state.put(user, 0l);
   }
+
+  public synchronized Optional<Long> getSum(String user)
+  {
+    return Optional.empty();
+  }
 }
diff --git a/src/test/java/de/juplo/kafka/SumBusinessLogicTest.java b/src/test/java/de/juplo/kafka/SumBusinessLogicTest.java
index 27c317a..ff9fdd0 100644
--- a/src/test/java/de/juplo/kafka/SumBusinessLogicTest.java
+++ b/src/test/java/de/juplo/kafka/SumBusinessLogicTest.java
@@ -24,4 +24,21 @@ public class SumBusinessLogicTest
     sumBusinessLogic.startSum("foo");
     assertThatIllegalStateException().isThrownBy(() -> sumBusinessLogic.startSum("foo"));
   }
+
+  @Test
+  @DisplayName("An empty Optional should be returned, for a non-existing sum")
+  public void testEmptyOptionalForNonExistingSum()
+  {
+    SumBusinessLogic sumBusinessLogic = new SumBusinessLogic();
+    assertThat(sumBusinessLogic.getSum("foo")).isEmpty();
+  }
+
+  @Test
+  @DisplayName("A non-empty Optional should be returned, for an existing sum")
+  public void testNonEmptyOptionalForExistingSum()
+  {
+    SumBusinessLogic sumBusinessLogic = new SumBusinessLogic();
+    sumBusinessLogic.startSum("foo");
+    assertThat(sumBusinessLogic.getSum("foo")).isNotEmpty();
+  }
 }