From d749ee8f5f051cf777de955408257b51001f4835 Mon Sep 17 00:00:00 2001 From: Kai Moritz Date: Fri, 10 Jan 2025 23:01:04 +0100 Subject: [PATCH] Mocking mit `@Mock` auf Klassenebene erspart Parameter-Schlacht --- .../java/de/juplo/kafka/BackOffStateTest.java | 147 ++++++------------ 1 file changed, 44 insertions(+), 103 deletions(-) diff --git a/src/test/java/de/juplo/kafka/BackOffStateTest.java b/src/test/java/de/juplo/kafka/BackOffStateTest.java index 5ee4e2b4..cb9d6418 100644 --- a/src/test/java/de/juplo/kafka/BackOffStateTest.java +++ b/src/test/java/de/juplo/kafka/BackOffStateTest.java @@ -25,6 +25,10 @@ class BackOffStateTest final static long OTHER_OFFSET = 1; final static Instant NOW = Instant.now(); + @Mock Clock clock; + @Mock BackOff backOff; + @Mock BackOffExecution backOffExecution; + private BackOffState NotStartedBackOffState() { @@ -71,10 +75,7 @@ class BackOffStateTest } - private BackOffState StartedBackoffStateWithNoRetries( - Clock clock, - BackOff backOff, - BackOffExecution backOffExecution) + private BackOffState StartedBackoffStateWithNoRetries() { given(clock.instant()).willReturn(NOW); given(backOff.start()).willReturn(backOffExecution); @@ -85,13 +86,10 @@ class BackOffStateTest @Test @DisplayName("A started BackOffState with no retries is not waiting for a retry") - void StartedBackOffStateWithNoRetriesIsNotWaitingForRetry( - @Mock Clock clock, - @Mock BackOff backOff, - @Mock BackOffExecution backOffExecution) + void StartedBackOffStateWithNoRetriesIsNotWaitingForRetry() { // GIVEN - BackOffState backOffState = StartedBackoffStateWithNoRetries(clock, backOff, backOffExecution); + BackOffState backOffState = StartedBackoffStateWithNoRetries(); // WHEN @@ -101,13 +99,10 @@ class BackOffStateTest @Test @DisplayName("A started BackOffState with no retries is started") - void StartedBackOffStateWithNoRetriesIsStarted( - @Mock Clock clock, - @Mock BackOff backOff, - @Mock BackOffExecution backOffExecution) + void StartedBackOffStateWithNoRetriesIsStarted() { // GIVEN - BackOffState backOffState = StartedBackoffStateWithNoRetries(clock, backOff, backOffExecution); + BackOffState backOffState = StartedBackoffStateWithNoRetries(); // WHEN @@ -117,13 +112,10 @@ class BackOffStateTest @Test @DisplayName("A started BackOffState with no retries is completed") - void StartedBackOffStateWithNoRetriesIsCompleted( - @Mock Clock clock, - @Mock BackOff backOff, - @Mock BackOffExecution backOffExecution) + void StartedBackOffStateWithNoRetriesIsCompleted() { // GIVEN - BackOffState backOffState = StartedBackoffStateWithNoRetries(clock, backOff, backOffExecution); + BackOffState backOffState = StartedBackoffStateWithNoRetries(); // WHEN @@ -132,10 +124,7 @@ class BackOffStateTest } - private BackOffState StartedBackoffStateWithRetries( - Clock clock, - BackOff backOff, - BackOffExecution backOffExecution) + private BackOffState StartedBackoffStateWithRetries() { given(clock.instant()).willReturn(NOW); given(backOff.start()).willReturn(backOffExecution); @@ -146,13 +135,10 @@ class BackOffStateTest @Test @DisplayName("A started BackOffState is waiting for a retry if the time is not due") - void StartedBackOffStateIsWaitingForRetryIfTimeIsNotDue( - @Mock Clock clock, - @Mock BackOff backOff, - @Mock BackOffExecution backOffExecution) + void StartedBackOffStateIsWaitingForRetryIfTimeIsNotDue() { // GIVEN - BackOffState backOffState = StartedBackoffStateWithRetries(clock, backOff, backOffExecution); + BackOffState backOffState = StartedBackoffStateWithRetries(); given(clock.instant()).willReturn(NOW.plusMillis(1000)); // WHEN @@ -164,13 +150,10 @@ class BackOffStateTest @Test @DisplayName("A started BackOffState is started if the time is not due") - void StartedBackOffStateIsStarted( - @Mock Clock clock, - @Mock BackOff backOff, - @Mock BackOffExecution backOffExecution) + void StartedBackOffStateIsStarted() { // GIVEN - BackOffState backOffState = StartedBackoffStateWithRetries(clock, backOff, backOffExecution); + BackOffState backOffState = StartedBackoffStateWithRetries(); given(clock.instant()).willReturn(NOW.plusMillis(1000)); // WHEN @@ -182,13 +165,10 @@ class BackOffStateTest @Test @DisplayName("A started BackOffState is not started for other offsets if the time is not due") - void StartedBackOffStateIsNotStartedForOtherOffsetsIfTheTimeIsNotDue( - @Mock Clock clock, - @Mock BackOff backOff, - @Mock BackOffExecution backOffExecution) + void StartedBackOffStateIsNotStartedForOtherOffsetsIfTheTimeIsNotDue() { // GIVEN - BackOffState backOffState = StartedBackoffStateWithRetries(clock, backOff, backOffExecution); + BackOffState backOffState = StartedBackoffStateWithRetries(); given(clock.instant()).willReturn(NOW.plusMillis(1000)); // WHEN @@ -200,13 +180,10 @@ class BackOffStateTest @Test @DisplayName("A started BackOffState is not completed if the time is not due") - void StartedBackOffStateIsNotCompletedIfTimeIsNotDue( - @Mock Clock clock, - @Mock BackOff backOff, - @Mock BackOffExecution backOffExecution) + void StartedBackOffStateIsNotCompletedIfTimeIsNotDue() { // GIVEN - BackOffState backOffState = StartedBackoffStateWithRetries(clock, backOff, backOffExecution); + BackOffState backOffState = StartedBackoffStateWithRetries(); given(clock.instant()).willReturn(NOW.plusMillis(1000)); // WHEN @@ -218,13 +195,10 @@ class BackOffStateTest @Test @DisplayName("A started BackOffState is not waiting for a retry if the time is due but the retry not yet completed") - void StartedBackOffStateIsNotWaitingForRetryIfTheTimeIsDueButRetryNotCompleted( - @Mock Clock clock, - @Mock BackOff backOff, - @Mock BackOffExecution backOffExecution) + void StartedBackOffStateIsNotWaitingForRetryIfTheTimeIsDueButRetryNotCompleted() { // GIVEN - BackOffState backOffState = StartedBackoffStateWithRetries(clock, backOff, backOffExecution); + BackOffState backOffState = StartedBackoffStateWithRetries(); given(clock.instant()).willReturn(NOW.plusMillis(1001)); given(backOffExecution.nextBackOff()).willReturn(1000l); @@ -237,13 +211,10 @@ class BackOffStateTest @Test @DisplayName("A started BackOffState is started if the time is due but the retry not yet completed") - void StartedBackOffStateIsStartedIfTheTimeIsDueButRetryNotCompleted( - @Mock Clock clock, - @Mock BackOff backOff, - @Mock BackOffExecution backOffExecution) + void StartedBackOffStateIsStartedIfTheTimeIsDueButRetryNotCompleted() { // GIVEN - BackOffState backOffState = StartedBackoffStateWithRetries(clock, backOff, backOffExecution); + BackOffState backOffState = StartedBackoffStateWithRetries(); given(clock.instant()).willReturn(NOW.plusMillis(1001)); given(backOffExecution.nextBackOff()).willReturn(1000l); @@ -256,13 +227,10 @@ class BackOffStateTest @Test @DisplayName("A started BackOffState is not started for other offsets if the time is due but the retry not yet completed") - void StartedBackOffStateIsNotStartedForOtherOffsetsIfTheTimeIsDueButRetryNotCompleted( - @Mock Clock clock, - @Mock BackOff backOff, - @Mock BackOffExecution backOffExecution) + void StartedBackOffStateIsNotStartedForOtherOffsetsIfTheTimeIsDueButRetryNotCompleted() { // GIVEN - BackOffState backOffState = StartedBackoffStateWithRetries(clock, backOff, backOffExecution); + BackOffState backOffState = StartedBackoffStateWithRetries(); given(clock.instant()).willReturn(NOW.plusMillis(1001)); given(backOffExecution.nextBackOff()).willReturn(1000l); @@ -275,13 +243,10 @@ class BackOffStateTest @Test @DisplayName("A started BackOffState is not completed if the time is due but the retry not yet completed") - void StartedBackOffStateIsNotCompletedIfTheTimeIsDueButRetryNotCompleted( - @Mock Clock clock, - @Mock BackOff backOff, - @Mock BackOffExecution backOffExecution) + void StartedBackOffStateIsNotCompletedIfTheTimeIsDueButRetryNotCompleted() { // GIVEN - BackOffState backOffState = StartedBackoffStateWithRetries(clock, backOff, backOffExecution); + BackOffState backOffState = StartedBackoffStateWithRetries(); given(clock.instant()).willReturn(NOW.plusMillis(1001)); given(backOffExecution.nextBackOff()).willReturn(1000l); @@ -294,13 +259,10 @@ class BackOffStateTest @Test @DisplayName("A started BackOffState is not waiting for a retry if the time is due and the retry is completed") - void StartedBackOffStateIsNotWaitingForRetryIfTheTimeIsDueAndRetryIsCompleted( - @Mock Clock clock, - @Mock BackOff backOff, - @Mock BackOffExecution backOffExecution) + void StartedBackOffStateIsNotWaitingForRetryIfTheTimeIsDueAndRetryIsCompleted() { // GIVEN - BackOffState backOffState = StartedBackoffStateWithRetries(clock, backOff, backOffExecution); + BackOffState backOffState = StartedBackoffStateWithRetries(); given(clock.instant()).willReturn(NOW.plusMillis(1001)); given(backOffExecution.nextBackOff()).willReturn(BackOffExecution.STOP); @@ -313,13 +275,10 @@ class BackOffStateTest @Test @DisplayName("A started BackOffState is started if the time is due and the retry is completed") - void StartedBackOffStateIsStartedIfTheTimeIsDueAndRetryIsCompleted( - @Mock Clock clock, - @Mock BackOff backOff, - @Mock BackOffExecution backOffExecution) + void StartedBackOffStateIsStartedIfTheTimeIsDueAndRetryIsCompleted() { // GIVEN - BackOffState backOffState = StartedBackoffStateWithRetries(clock, backOff, backOffExecution); + BackOffState backOffState = StartedBackoffStateWithRetries(); given(clock.instant()).willReturn(NOW.plusMillis(1001)); given(backOffExecution.nextBackOff()).willReturn(BackOffExecution.STOP); @@ -332,13 +291,10 @@ class BackOffStateTest @Test @DisplayName("A started BackOffState is not started for other offsets if the time is due and the retry is completed") - void StartedBackOffStateIsNotStartedForOtherOffsetsIfTheTimeIsDueAndRetryIsCompleted( - @Mock Clock clock, - @Mock BackOff backOff, - @Mock BackOffExecution backOffExecution) + void StartedBackOffStateIsNotStartedForOtherOffsetsIfTheTimeIsDueAndRetryIsCompleted() { // GIVEN - BackOffState backOffState = StartedBackoffStateWithRetries(clock, backOff, backOffExecution); + BackOffState backOffState = StartedBackoffStateWithRetries(); given(clock.instant()).willReturn(NOW.plusMillis(1001)); given(backOffExecution.nextBackOff()).willReturn(BackOffExecution.STOP); @@ -351,13 +307,10 @@ class BackOffStateTest @Test @DisplayName("A started BackOffState is completed if the time is due and the retry is completed") - void StartedBackOffStateIsCompletedIfTheTimeIsDueAndRetryIsCompleted( - @Mock Clock clock, - @Mock BackOff backOff, - @Mock BackOffExecution backOffExecution) + void StartedBackOffStateIsCompletedIfTheTimeIsDueAndRetryIsCompleted() { // GIVEN - BackOffState backOffState = StartedBackoffStateWithRetries(clock, backOff, backOffExecution); + BackOffState backOffState = StartedBackoffStateWithRetries(); given(clock.instant()).willReturn(NOW.plusMillis(1001)); given(backOffExecution.nextBackOff()).willReturn(BackOffExecution.STOP); @@ -370,13 +323,10 @@ class BackOffStateTest @Test @DisplayName("A started BackOffState is not waiting for a retry if it is marked as completed") - void StartedBackOffStateIsNotWaitingForRetryIfMarkedCompleted( - @Mock Clock clock, - @Mock BackOff backOff, - @Mock BackOffExecution backOffExecution) + void StartedBackOffStateIsNotWaitingForRetryIfMarkedCompleted() { // GIVEN - BackOffState backOffState = StartedBackoffStateWithRetries(clock, backOff, backOffExecution); + BackOffState backOffState = StartedBackoffStateWithRetries(); // WHEN backOffState.markAsCompleted(); @@ -387,13 +337,10 @@ class BackOffStateTest @Test @DisplayName("A started BackOffState is not started if it is marked as completed") - void StartedBackOffStateIsNotStartedIfMarkedCompleted( - @Mock Clock clock, - @Mock BackOff backOff, - @Mock BackOffExecution backOffExecution) + void StartedBackOffStateIsNotStartedIfMarkedCompleted() { // GIVEN - BackOffState backOffState = StartedBackoffStateWithRetries(clock, backOff, backOffExecution); + BackOffState backOffState = StartedBackoffStateWithRetries(); // WHEN backOffState.markAsCompleted(); @@ -404,13 +351,10 @@ class BackOffStateTest @Test @DisplayName("A started BackOffState is not started for other offsets if it is marked as completed") - void StartedBackOffStateIsNotStartedForOtherOffsetsIfMarkedCompleted( - @Mock Clock clock, - @Mock BackOff backOff, - @Mock BackOffExecution backOffExecution) + void StartedBackOffStateIsNotStartedForOtherOffsetsIfMarkedCompleted() { // GIVEN - BackOffState backOffState = StartedBackoffStateWithRetries(clock, backOff, backOffExecution); + BackOffState backOffState = StartedBackoffStateWithRetries(); // WHEN backOffState.markAsCompleted(); @@ -421,13 +365,10 @@ class BackOffStateTest @Test @DisplayName("A started BackOffState is not completed if it is marked as completed") - void StartedBackOffStateIsNotCompletedIfMarkedCompleted( - @Mock Clock clock, - @Mock BackOff backOff, - @Mock BackOffExecution backOffExecution) + void StartedBackOffStateIsNotCompletedIfMarkedCompleted() { // GIVEN - BackOffState backOffState = StartedBackoffStateWithRetries(clock, backOff, backOffExecution); + BackOffState backOffState = StartedBackoffStateWithRetries(); // WHEN backOffState.markAsCompleted(); -- 2.20.1